Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 6925 inventory builder tests failing #6926

Closed
wants to merge 2 commits into from
Closed

Issue 6925 inventory builder tests failing #6926

wants to merge 2 commits into from

Conversation

OwenTuz
Copy link
Contributor

@OwenTuz OwenTuz commented Nov 18, 2020

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

  • Fixes some very minor PEP8 problems that were causing CI to fail
  • Changes tox's Python requirement from 3.3 (deprecated) to 3.x

Which issue(s) this PR fixes:
Fixes #6925

Special notes for your reviewer:

The PEP8 parts are minor, and the Python version change is probably the biggest change here.

For the initial PR I've gone with whatever python3 means on a user's system as this caters for a wide range of developer platforms (Ubuntu 20.04 ships with Python 3.8, CentOS 8 ships with Python 3.6 and so on) and should mean less maintenance in future as Python keeps moving.

However this opens us up to CI failures and potential inconsistencies if in future there are breaking changes between Python versions.

Personally I get the impression that the inventory-builder is a small enough and infrequently-enough changed piece of code that it's probably preferable to take the more simple path, and to be notified by CI pain if something breaks in future. However I'm happy to change this and pin to a more specific version if anyone feels strongly.

Does this PR introduce a user-facing change?:

NONE

@OwenTuz
Allow Python versions greater than 3.3 for inventory-builder tests
0186701 
Python 3.3 is deprecated and produces warnings.
This change relaxes the requirement to allow any version of Python 3.
@OwenTuz
Fix PEP8 problems (AssertTrue vs AssertIn)
b319a91
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 18, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @OwenTuz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 18, 2020
@k8s-ci-robot k8s-ci-robot requested a review from EppO November 18, 2020 13:24
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: OwenTuz
To complete the pull request process, please assign mattymo after the PR has been reviewed.
You can assign the PR to them by writing /assign @mattymo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 18, 2020
@floryut
Copy link
Member

floryut commented Nov 18, 2020

@OwenTuz Thank you for the PR, but this is already fix in #6910 :)

@OwenTuz OwenTuz closed this Nov 18, 2020
@OwenTuz OwenTuz deleted the issue-6925-inventory-builder-tests-failing branch November 18, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO Awaiting requested review from EppO

@holmsten holmsten Awaiting requested review from holmsten

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PEP8-related test failures in inventory-builder CI
3 participants
@OwenTuz @k8s-ci-robot @floryut